Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

Empty handler for initialized notification - #384

Merged
felixfbecker merged 2 commits into
sourcegraph:masterfrom
tomv564:handle-initialized-notification
Oct 31, 2017
Merged

Empty handler for initialized notification#384
felixfbecker merged 2 commits into
sourcegraph:masterfrom
tomv564:handle-initialized-notification

Conversation

@tomv564

@tomv564 tomv564 commented Oct 26, 2017

Copy link
Copy Markdown
Contributor

The language server currently logs a warning when the initialized notification is received.

As we are not dynamically registering capabilities on the client, there should be nothing to do but silently handle the notification?

See: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#new-initialized-notification

@codecov

codecov Bot commented Oct 26, 2017

Copy link
Copy Markdown

Codecov Report

Merging #384 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          15       15           
  Lines        1765     1765           
  Branches      333      333           
=======================================
  Hits         1317     1317           
  Misses        296      296           
  Partials      152      152
Impacted Files Coverage Δ
src/typescript-service.ts 72.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34ac0b...3b463ff. Read the comment docs.

Comment thread src/typescript-service.ts
.startWith({ op: 'add', path: '', value: { changes: {} } as WorkspaceEdit } as Operation)
}

public async initialized(): Promise<void> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please copy over the description

@felixfbecker
felixfbecker merged commit 5fb0b73 into sourcegraph:master Oct 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants